Bump webdriverio to v9#4594
Bump webdriverio to v9#4594DavertMik merged 36 commits intocodeceptjs:3.xfrom thomashohn:task-4593-bump-webdriverio
Conversation
|
@kobenguyent - did some initial work here - some tests still might need to be adapted - will see if I find the time for that |
|
@kobenguyent Fixed some of the tests feel free to pick up on the last ones |
lib/helper/WebDriver.js
Outdated
| if (Number.isInteger(locator)) { | ||
| return this.browser.switchToFrame(locator) | ||
| // @TODO construct array of iFrames and pick "index" | ||
| let locator1 = new Locator('//iframe[@id="number-frame-1234"]', 'xpath') |
There was a problem hiding this comment.
I guess we forgot to adjust this hardcoded id?
There was a problem hiding this comment.
I think we need to fetch a list of iframes dynamically and then fetch the corresponding index?
There was a problem hiding this comment.
well, I'm not having much knowledge on this, but I guess, we shall query the iframe based on the passed locator and switch to that frame if found, otherwise, we shall throw an error as no frame to switch to, what do you think.
There was a problem hiding this comment.
The locator passed is a number i guess in previous versions that what have returned the frame with that index - we might need to either investigate if this should be possible in the new version or not. Could not find a method to get all iframes on a page - yop might now a way?
There was a problem hiding this comment.
https://codecept.io/helpers/WebDriver/#switchto looks like it's either a locator or nothing.
There was a problem hiding this comment.
Then I guess it should be adapted to that together with the tests - I could do that
|
@thomashohn @kobenguyent is there a chance we can get tests fixes and merged? |
|
@DavertMik - my problem is that the remaining issues are outside my experience - so I was hoping that somebody with experience in the webdriver.io area could take over the remaining stuff |
|
@thomashohn Skipping some tests:
|
3 participants
Motivation/Description of the PR
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)